Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23521 - update continuation emails #3036

Merged
merged 11 commits into from
Oct 25, 2024
Merged

23521 - update continuation emails #3036

merged 11 commits into from
Oct 25, 2024

Conversation

ketaki-deodhar
Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar commented Oct 24, 2024 •
edited
Loading

Issue #: /bcgov/entity#23521

Description of changes:

  • updated Continuation Authorization emails
  • updated Continuation completion emails

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@ketaki-deodhar ketaki-deodhar self-assigned this Oct 24, 2024
@ketaki-deodhar ketaki-deodhar marked this pull request as ready for review October 24, 2024 21:49
ArwenQin
ArwenQin approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vysakh-menon-aot
Copy link
Collaborator

As Mihai mentioned in todays standup we need to feature flag the NR template changes (you can create separate PR for NR templates with FF)

@ketaki-deodhar
Copy link
Collaborator Author

As Mihai mentioned in todays standup we need to feature flag the NR template changes (you can create separate PR for NR templates with FF)

Sure. Will do. I believe there will be discussion about it and will apply changes after that.

@vysakh-menon-aot
Copy link
Collaborator

As Mihai mentioned in todays standup we need to feature flag the NR template changes (you can create separate PR for NR templates with FF)

Sure. Will do. I believe there will be discussion about it and will apply changes after that.

You have to exclude NR templates from this PR (since it should not go to PROD without FF)

@ketaki-deodhar
Copy link
Collaborator Author

As Mihai mentioned in todays standup we need to feature flag the NR template changes (you can create separate PR for NR templates with FF)

Sure. Will do. I believe there will be discussion about it and will apply changes after that.

You have to exclude NR templates from this PR (since it should not go to PROD without FF)

You mean take NR templates from this PR altogether?

@ketaki-deodhar
Copy link
Collaborator Author

ketaki-deodhar commented Oct 24, 2024 •
edited
Loading

Will exclude all changes related to NR emails

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ketaki-deodhar ketaki-deodhar merged commit bcfa13a into bcgov:main Oct 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArwenQin ArwenQin ArwenQin approved these changes

@vysakh-menon-aot vysakh-menon-aot vysakh-menon-aot approved these changes

Assignees

@ketaki-deodhar ketaki-deodhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ketaki-deodhar @vysakh-menon-aot @ArwenQin